Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of multiple IPs for mojang requests #52

Open
wagpa opened this issue Mar 2, 2024 · 2 comments
Open

Allow usage of multiple IPs for mojang requests #52

wagpa opened this issue Mar 2, 2024 · 2 comments

Comments

@wagpa
Copy link
Contributor Author

wagpa commented Mar 4, 2024

We see three general options:

  1. place load balancer / reverse proxy in front of xenos
  2. in xenos, use something like a message queue
  3. place proxy behind xenos

Option (1) is problematic in that it would not work nicely with sessions. It could be implemented using the healthy/ready status indicating that all mojang request token have been used up. Problematic with bursts.

Option (3) could be done, but contradicts the goal of xenos. Originally, xenos should ensure that requests could be made.

Option (2) would probably be the best feature wise. It could implement integrate request deduplication. But it probably comes at
high development costs.

Another Option (4) would be to keep sessions with multiple xenos instances in each client. But this would only work (nicely) inside the cluster. The clients wouldn't be able to synchonise usages and deduplicatuion wouldn't be used.

@scrayos
Copy link
Member

scrayos commented Mar 5, 2024

To follow up on the "one node has multiple IPs that it can utilize": That should be possible with this: https://docs.rs/reqwest/latest/reqwest/struct.ClientBuilder.html#method.local_address

We can just specify the local address then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants