Impact
If you use HttpAuthMiddleware (i.e. the http_user and http_pass spider attributes) for HTTP authentication, all requests will expose your credentials to the request target.
This includes requests generated by Scrapy components, such as robots.txt requests sent by Scrapy when the ROBOTSTXT_OBEY setting is set to True, or as requests reached through redirects.
Patches
Upgrade to Scrapy 2.5.1 and use the new http_auth_domain spider attribute to control which domains are allowed to receive the configured HTTP authentication credentials.
If you are using Scrapy 1.8 or a lower version, and upgrading to Scrapy 2.5.1 is not an option, you may upgrade to Scrapy 1.8.1 instead.
Workarounds
If you cannot upgrade, set your HTTP authentication credentials on a per-request basis, using for example the w3lib.http.basic_auth_header function to convert your credentials into a value that you can assign to the Authorization header of your request, instead of defining your credentials globally using HttpAuthMiddleware.
For more information
If you have any questions or comments about this advisory:
Impact
If you use
HttpAuthMiddleware(i.e. thehttp_userandhttp_passspider attributes) for HTTP authentication, all requests will expose your credentials to the request target.This includes requests generated by Scrapy components, such as
robots.txtrequests sent by Scrapy when theROBOTSTXT_OBEYsetting is set toTrue, or as requests reached through redirects.Patches
Upgrade to Scrapy 2.5.1 and use the new
http_auth_domainspider attribute to control which domains are allowed to receive the configured HTTP authentication credentials.If you are using Scrapy 1.8 or a lower version, and upgrading to Scrapy 2.5.1 is not an option, you may upgrade to Scrapy 1.8.1 instead.
Workarounds
If you cannot upgrade, set your HTTP authentication credentials on a per-request basis, using for example the
w3lib.http.basic_auth_headerfunction to convert your credentials into a value that you can assign to theAuthorizationheader of your request, instead of defining your credentials globally usingHttpAuthMiddleware.For more information
If you have any questions or comments about this advisory: