Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_import _path #6225

Open
Gallaecio opened this issue Feb 16, 2024 · 3 comments
Open

Implement get_import _path #6225

Gallaecio opened this issue Feb 16, 2024 · 3 comments

Comments

@Gallaecio
Copy link
Member

I think we should do the following:

Deprecate scrapy.utils.python.get_global_object in favor of a new function named get_import_path, and replace all usages.

Make the argument of get_import_path a positional-only argument, since obj could be a confusing name when passing a class (class instances are not supported).

Find uses of __module__, __name__, and __qualname__, and where appropriate replace them with the new function.

However, we should probably discuss this before someone starts implementing it. Maybe this should be implemented elsewhere, or we should choose a different naming or implementation.

@Noman654

This comment was marked as off-topic.

@Gallaecio

This comment was marked as off-topic.

@Noman654

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants