Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a warning if options -o or -O are specified when FeedExporter is disabled #5970

Open
Prometheus3375 opened this issue Jul 10, 2023 · 1 comment · May be fixed by #6082
Open

Emit a warning if options -o or -O are specified when FeedExporter is disabled #5970

Prometheus3375 opened this issue Jul 10, 2023 · 1 comment · May be fixed by #6082

Comments

@Prometheus3375
Copy link

Summary

In order to export the results of crawling to a file, FeedExporter must be enabled. This extension can be disabled via EXTENSIONS and EXTENSIONS_BASE settings; in such case options -o and -O does nothing.

Motivation

The cmdline help does not note that FeedExporter must be enabled to make output options work. So when I noticed that no output file was generated, I started to seek for the issue. I found out, that FeedExporter is disabled in our default configuration, because we make no use of it in production.

A warning or a note in help message will definitely assist in identifying the problem.

@Gallaecio
Copy link
Member

Maybe we could have the command for it being enabled, and log a warning about it just in case.

@buungoo buungoo linked a pull request Oct 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants