Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the dirty reactor errors #5961

Open
wRAR opened this issue Jun 25, 2023 · 1 comment
Open

Fixing the dirty reactor errors #5961

wRAR opened this issue Jun 25, 2023 · 1 comment
Labels

Comments

@wRAR
Copy link
Member

wRAR commented Jun 25, 2023

I started investigating random test failures that have "'NoneType' object is not iterable" / "twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.". It turned out that DirtyReactorAggregateError is the actual problem and "'NoneType' object is not iterable" is printed by pytest when investigating the exception info. I've also found that running tests/test_downloader_handlers.py tests is enough to get this (I'm actually not sure if this error happens in other tests). I think as the next step we should review the test cases to see if there are any resources obviously not being cleaned up.

@wRAR
Copy link
Member Author

wRAR commented Jun 29, 2023

After some more stress testing it looks like the majority of failures in tests/test_downloader_handlers.py are the same tests we already disabled on Windows+asyncio because they always failed there (twisted/twisted#10279), though other tests can fail as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant