Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review url being optional for SplashRequest #270

Open
Gallaecio opened this issue Oct 11, 2020 · 2 comments
Open

Review url being optional for SplashRequest #270

Gallaecio opened this issue Oct 11, 2020 · 2 comments

Comments

@Gallaecio
Copy link
Contributor

Gallaecio commented Oct 11, 2020 •
edited

As part of #269, the url parameter to SplashRequest is no longer optional.

@elacuesta noticed that this is a backward-incompatible change. Moreover, the upcoming Scrapy 2.4 will make this change unnecessary (scrapy/scrapy#4835).

We should consider reverting that part of #269.
@lopuhin
Copy link
Contributor

lopuhin commented Oct 12, 2020

sounds good to me, thanks for the heads up @Gallaecio

@Rafiot
Copy link
Contributor

Rafiot commented Oct 13, 2020 •
edited

Reverting 4154782 will do just that, so just go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rafiot @lopuhin @Gallaecio