Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: drop using six module #295

Open
kloczek opened this issue Apr 23, 2022 · 1 comment · May be fixed by #306
Open

RFE: drop using six module #295

kloczek opened this issue Apr 23, 2022 · 1 comment · May be fixed by #306

Comments

@kloczek
Copy link

kloczek commented Apr 23, 2022

https://adamj.eu/tech/2019/03/13/dropping-python-2-support/

Looking on the code

[tkloczko@devel-g2v scour-0.38.2]$ grep -rw six
scour/scour.py:import six
scour/scour.py:from six.moves import range, urllib
scour/scour.py:    for rid, nodes in six.iteritems(findReferencedElements(doc.documentElement)):
scour/scour.py:        for bucket in six.itervalues(grad_buckets):
scour/scour.py:        sci = six.text_type(length) + 'e' + six.text_type(exponent)
scour/svg_transform.py:from six.moves import range
setup.py:    install_requires=['six>=1.9.0'],
test_scour.py:import six
test_scour.py:from six.moves import map, range
test_scour.py:        desc = six.text_type(doc.getElementsByTagNameNS(SVGNS, 'desc')[0].firstChild.wholeText).strip()
test_scour.py:        desc = six.text_type(doc.getElementsByTagNameNS(SVGNS, 'desc')[1].firstChild.wholeText).strip()
test_scour.py:        desc = six.text_type(doc.getElementsByTagNameNS(SVGNS, 'desc')[2].firstChild.wholeText).strip()
test_scour.py:        desc = six.text_type(doc.getElementsByTagNameNS(SVGNS, 'desc')[3].firstChild.wholeText).strip()
test_scour.py:        desc = six.text_type(doc.getElementsByTagNameNS(SVGNS, 'desc')[0].firstChild.wholeText).strip()
test_scour.py:        class InOutBuffer(six.StringIO, object):
tox.ini:    six
@kytta kytta linked a pull request Jan 23, 2023 that will close this issue
@kloczek
Copy link
Author

kloczek commented Mar 9, 2024

Only now I found #306.
I've tested it and looks like it works.
Is it possible to commit this PR and release new version? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant