Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on second dose instead of first dose #2

Open
srakrn opened this issue Sep 17, 2021 · 4 comments
Open

Focus on second dose instead of first dose #2

srakrn opened this issue Sep 17, 2021 · 4 comments

Comments

@srakrn
Copy link

srakrn commented Sep 17, 2021

Currently, the design of the pass in Apple Wallet seemed to "focus" on the first dose of vaccine (with the larger font size on the name of the vaccine the user get). To my understanding, the inequal font size is a result of the limitations on the pass's layout.

In such a case, is it more intuitive to focus on the second dose since it means a single person is fully vaccinated, and is certified for a vaccination certificate?

@scomma
Copy link
Owner

scomma commented Sep 17, 2021

You're correct to intuit that the pass layout forces font sizes. To my knowledge it also forces the first one ("secondary field") to be larger than the second one ("auxiliary field"), so the only way to achieve that effect would be to list the doses in reverse chronological order (dose 2 on top). I'm afraid of straying too far from the original format. Thoughts?

pass.secondaryFields.add("level", new Date(req.query.dose1date).toDateString(), dose1);
pass.auxiliaryFields.add("aux", new Date(req.query.dose2date).toDateString(), dose2);

@srakrn
Copy link
Author

srakrn commented Sep 18, 2021

From my perspective, if the pass clearly indicates the arrangement of the dose, then I don't have any kind of problems. Chronologically reversed ordering is not something uncommon (social media feed widely adapts them, for example).

But I forgot to take the original vaccination certificate's design into consideration, thus I would say I could not give any constructive feedbacks or comments when considering such a limitation.

@scomma
Copy link
Owner

scomma commented Sep 18, 2021

Ok, I'll leave this issue open for while in case anyone wants to pile on. In the meantime since we're not importing directly from MOPH API (yet), anyone who prefers reverse chronology is free to swap their first/second dose data in the interface.

@srakrn
Copy link
Author

srakrn commented Sep 20, 2021

image

I tried the reversed chronological order with some text added to clarify the ordering. Interestingly, it appears that the text in both fields shrinks in font size to fit a longer line length to the screen size.

Not sure if we can apply whitespace hacks to make the size of the two lines as close as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants