We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instead of copying all the files, we should follow what https://github.com/sclorg/s2i-php-container/blob/master/7.0/s2i/bin/assemble does, which is:
shopt -s dotglob echo "---> Installing application source..." mv /tmp/src/* ./
This prevents moving the .git directory with it.
In addition, I'm not sure I see a need to cat the default.vcl file on each build. What is the use besides the occasional debugging?
The text was updated successfully, but these errors were encountered:
@michaelryanmcneill Thanks. PullRequests are really welcomed.
rsync will probably be used. See ongoing discussion sclorg/s2i-nodejs-container#182
rsync
Sorry, something went wrong.
@michaelryanmcneill Can you please file a PR, including test suite?
Fixes: #42 Moving sources instead of copying sources like it is done
cd534f5
here: https://github.com/sclorg/s2i-php-container/blob/master/8.1/s2i/bin/assemble#L7 Closes: #42 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Successfully merging a pull request may close this issue.
Instead of copying all the files, we should follow what https://github.com/sclorg/s2i-php-container/blob/master/7.0/s2i/bin/assemble does, which is:
This prevents moving the .git directory with it.
In addition, I'm not sure I see a need to cat the default.vcl file on each build. What is the use besides the occasional debugging?
The text was updated successfully, but these errors were encountered: