Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assemble process should be cleaner #42

Open
michaelryanmcneill opened this issue Apr 10, 2018 · 2 comments · May be fixed by #141
Open

Assemble process should be cleaner #42

michaelryanmcneill opened this issue Apr 10, 2018 · 2 comments · May be fixed by #141

Comments

@michaelryanmcneill
Copy link

Instead of copying all the files, we should follow what https://github.com/sclorg/s2i-php-container/blob/master/7.0/s2i/bin/assemble does, which is:

shopt -s dotglob
echo "---> Installing application source..."
mv /tmp/src/* ./

This prevents moving the .git directory with it.

In addition, I'm not sure I see a need to cat the default.vcl file on each build. What is the use besides the occasional debugging?
@omron93
Copy link
Contributor

omron93 commented Apr 11, 2018

@michaelryanmcneill Thanks. PullRequests are really welcomed.

Instead of copying all the files, we should follow what https://github.com/sclorg/s2i-php-container/blob/master/7.0/s2i/bin/assemble does, which is:

rsync will probably be used. See ongoing discussion sclorg/s2i-nodejs-container#182

@phracek
Copy link
Member

phracek commented Apr 17, 2024

@michaelryanmcneill Can you please file a PR, including test suite?

phracek added a commit that referenced this issue Apr 17, 2024
@phracek
Fixes: #42 Moving sources instead of copying sources like it is done
cd534f5 
here: https://github.com/sclorg/s2i-php-container/blob/master/8.1/s2i/bin/assemble#L7

Closes: #42

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek linked a pull request Apr 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

This pull request fixes issue 42 sclorg/varnish-container
3 participants
@michaelryanmcneill @phracek @omron93