Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get git_url and git_ref from the current repo #185

Open
LecrisUT opened this issue May 6, 2024 · 3 comments
Open

Get git_url and git_ref from the current repo #185

LecrisUT opened this issue May 6, 2024 · 3 comments
Labels
good first issue Good for newcomers type: feature New feature or request

Comments

@LecrisUT
Copy link

LecrisUT commented May 6, 2024

There are variables like ${{ github.ref }}/$GITHUB_REF (and more specific ones within action toolkit) to automatically extract the git repo.

Preferably it should use the results from actions/checkout, but that may be difficult given the current testing-farm api :/

@jamacku jamacku added type: feature New feature or request good first issue Good for newcomers labels May 6, 2024
@zmiklank
Copy link
Member

zmiklank commented May 6, 2024

Hi.
I would say this approach is not the only one, or even default one that the user of tfaga can choose.
We, in sclorg, do not set in our tfaga workflows git_url or git_ref based on information from cloned repository. We have tmt plans stored separately.

So that would require adding another input for setting if we want to use git_ref and git_url from current repo. In my opinion is therefore more efficient to use explicitly the inputs we already have.

Please correct me, if otherwise.

@LecrisUT
Copy link
Author

LecrisUT commented May 6, 2024

What I was meaning to suggest is defaults, i.e. default all the values to either ${{ github.ref }} (if possible) or default them to empty and within the JS code, if they are empty fill in the defaults from the action-toolkit. This would not impact other users, but it would make the first-party user (one with tmt tree in the upstream repo) have less to research on how to set it up for push, pull, etc.

@zmiklank
Copy link
Member

zmiklank commented May 6, 2024

Oh, sure, I understand now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants