Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: Pino tests are failing #381

Open
lholmquist opened this issue Mar 2, 2023 · 3 comments
Open

clients: Pino tests are failing #381

lholmquist opened this issue Mar 2, 2023 · 3 comments

Comments

@lholmquist
Copy link
Member

the pino tests are having failures on these platforms in the testing farm:

Fedora Node 18
Fedora Node 16
RHEL9 - Unsubscribed host - node 16

cc @lholmquist @mhdawson

@pkubatrh
Copy link
Member

pkubatrh commented Mar 7, 2023

Discussed the failure of pino test case on the nodejs meeting for a bit, we have decided to try and pin a specific version of the module and test with that.
If we figure out the tests are still as flaky as they were before this change, let's focus on making the upstream pino test suite more hardened to failures.

@phracek
Copy link
Member

phracek commented Mar 20, 2023

What about having two tests? The first one will be freezed 'pino', 'faas' that should pass always. The other test will use the latest upstream versions, it will be marked as unstable in case of failure. See PR here: #342

@mhdawson
Copy link
Member

@phracek that sounds reasonable. One question I had is if the pino tests are flaky or have just never passed on RHEL 9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants