Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FB create-react-app #185

Open
vnugent opened this issue May 22, 2018 · 1 comment
Open

Support for FB create-react-app #185

vnugent opened this issue May 22, 2018 · 1 comment

Comments

@vnugent
Copy link

vnugent commented May 22, 2018

Is there a way to customize how node app is launched? For apps created with FB create-react-app I'd like to create an image with npm run build and serve contents from the ./build dir. At the moment when the pod starts, the app is built again with npm start,

@omron93
Copy link
Contributor

omron93 commented May 23, 2018

Is there a way to customize how node app is launched?

You can add your own .s2i/bin/run script into source code of our app. [1] Probably the most safest way is to copy https://github.com/sclorg/s2i-nodejs-container/blob/master/8/s2i/bin/run and change it to your needs.

@kasicka You understand it more. Does it make sense to add this somehow in our run script?

[1] https://blog.openshift.com/override-s2i-builder-scripts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants