Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add && to allow probe to execute correctly #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strangiato
Copy link

Resolves #148

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@phracek
Copy link
Member

phracek commented Feb 10, 2022

[test-all]

@phracek
Copy link
Member

phracek commented Feb 23, 2022

Let's test Testing Farm as GitHub Action

[test-all]

@@ -116,15 +116,15 @@
"initialDelaySeconds": 5,
"exec": {
"command": [ "/bin/sh", "-i", "-c",
"MYSQL_PWD=\"$MYSQL_PASSWORD\" mysqladmin -u $MYSQL_USER ping"]
"MYSQL_PWD=\"$MYSQL_PASSWORD\" && mysqladmin -u $MYSQL_USER ping"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in mariadb, but what about to use export MYSQL_PWD=\"$MYSQL_PASSWORD\" mysqladmin -u $MYSQL_USER ping

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phracek it has been a while since I originally raised this issue so I don't remember all of the details but the problem is that these are two commands without any delineator between them.

The export changes the scope of the variable but it is still two commands that need some sort of delineator.

I believe doing a command instead of && would also resolve the issue.

@phracek
Copy link
Member

phracek commented Sep 9, 2022

[test-all]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example Template Liveness/Readiness Probe Errors
3 participants