Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting #5

Open
sckott opened this issue Jul 4, 2015 · 3 comments
Open

Rate limiting #5

sckott opened this issue Jul 4, 2015 · 3 comments
Assignees
Milestone

Comments

@sckott
Copy link
Owner

sckott commented Jul 4, 2015

Creating a general purpose rate limiting helper would be useful i think. Aspects:

  • Arguments:
    • value - Limit value (e.g., 100)
    • period - Per time frame (e.g. sec, min, hr, day)
    • on_limit - what to do when limit reached? (see below)
    • May need extra arguments depending on API
  • on_limit -
    • stop - and give error message to use
    • warn - and give error message to use
    • queue - and give max time to wait in queue (if R session quits this queue gone)
@sckott sckott modified the milestone: v0.1 Sep 12, 2015
@sckott
Copy link
Owner Author

sckott commented Sep 12, 2015

There is server side rate limiting, which is intertwined with this

@sckott
Copy link
Owner Author

sckott commented Sep 12, 2015

use cases

  • user say what rate limits are, and thats it - then we check rate limit info if given for them, if not sadface
  • user say what rate limits are, and user set some limit < than max limit
  • user specify do something specific on hitting rate limit e.g, give warning or wait a certain amount of time before proceeding

sckott added a commit that referenced this issue Sep 12, 2015
not working yet in the request, but stubbed out at least
@sckott sckott self-assigned this Dec 31, 2015
@sckott
Copy link
Owner Author

sckott commented Jan 2, 2016

moving to next milestone, trying to get MVP out #10

@sckott sckott modified the milestones: v0.2, v0.1 Jan 2, 2016
@sckott sckott modified the milestones: v0.2, v0.3 Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant