Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repository and package to follow the pytest plugin naming convention #61

Open
3 tasks
Sheila-nk opened this issue Jul 10, 2023 · 6 comments
Open
3 tasks
Labels
enhancement New features w.r.t. the original refguide-check task

Comments

@Sheila-nk
Copy link
Collaborator

Sheila-nk commented Jul 10, 2023

All pytest plugins should follow the pytest_ prefix naming convention so they can be automatically included in the Pytest Plugin List.

  • rename repository
  • rename package
  • update all occurrences of the old names

First, we need to figure out a suitable name for the plugin, or we can use pytest_scpdt for now as a placeholder.

@ev-br ev-br added enhancement New features w.r.t. the original refguide-check task labels Jul 24, 2023
@ev-br
Copy link
Member

ev-br commented Sep 14, 2023

Ralf's suggestion was scipy_doctest. One other suggestion (from Stefan) was doctest_sp. I actually like the latter :-). @melissawm thoughts?

@melissawm
Copy link
Contributor

I like explicit names like scipy_doctest or doctest_scipy but feel free to disagree 😁

@Sheila-nk
Copy link
Collaborator Author

I like both scipy_doctest and doctest_scipy but shouldn't we follow the pytest naming convention? pytest_scipy_doctest?

@ev-br
Copy link
Member

ev-br commented Sep 15, 2023

Only if it's obligatory. IOW does not starting with pytest_ preclude the plugin discovery by pytest? Pytest is only one frontend IMO.

@Sheila-nk
Copy link
Collaborator Author

No, it doesn't. The only downside is that it will not be included in the pytest plugin list, which is fine.

@ev-br
Copy link
Member

ev-br commented Sep 15, 2023

Only if it's obligatory. IOW does not starting with pytest_ preclude the plugin discovery by pytest? Pytest is only one frontend IMO.

Can we manually add it to whatever list is that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features w.r.t. the original refguide-check task
Projects
None yet
Development

No branches or pull requests

3 participants