Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve the TrajDataFrame index during preprocessing operations #71

Open
FilippoSimini opened this issue Jan 21, 2020 · 1 comment · May be fixed by #108
Open

Preserve the TrajDataFrame index during preprocessing operations #71

FilippoSimini opened this issue Jan 21, 2020 · 1 comment · May be fixed by #108
Assignees
@FilippoSimini
Labels
invalid This doesn't seem right

Comments

@FilippoSimini
Copy link
Member

Currently, the preprocessing operations may not preserve the index of the points in the TrajDataFrame. Change modify the preprocessing functions using reset_index and set_index so that the original index is saved as a column and passed back after the preprocessing operations.
@FilippoSimini FilippoSimini added the invalid This doesn't seem right label Jan 21, 2020
@FilippoSimini FilippoSimini self-assigned this Jan 21, 2020
@jonpappalord jonpappalord added this to the April 2020 milestone Jan 29, 2020
@jonpappalord jonpappalord linked a pull request Aug 6, 2020 that will close this issue
✨ Preserve the TrajDataFrame index during preprocessing #108
Open
@jonpappalord jonpappalord removed a link to a pull request Aug 6, 2020
✨ Preserve the TrajDataFrame index during preprocessing #108
Open
@jonpappalord
Copy link
Member

@FilippoSimini, maybe a better solution could be to put in the index of the new TrajDataFrame generated from the preprocessing operation the values of the index in the original TrajDataFrame.

@gbarlacchi gbarlacchi removed this from the April 2020 milestone Aug 6, 2020
@gbarlacchi gbarlacchi linked a pull request Jan 15, 2021 that will close this issue
✨ Preserve the TrajDataFrame index during preprocessing #108
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FilippoSimini FilippoSimini

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Preserve the TrajDataFrame index during preprocessing bennati/scikit-mobility
3 participants
@gbarlacchi @jonpappalord @FilippoSimini