Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline.get_feature_names() #16807

Closed
jackwellsxyz opened this issue Mar 30, 2020 · 2 comments
Closed

pipeline.get_feature_names() #16807

jackwellsxyz opened this issue Mar 30, 2020 · 2 comments

Comments

@jackwellsxyz
Copy link

Describe the workflow you want to enable

This is possibly a duplicate of #6424. I'd love to do a pipeline.fit(X) with a pandas dataframe with named columns, then a pipeline.get_feature_names() as input into an eli5 explainer, with scikit-learn being smart enough to call get_feature_names() for those transformers it makes sense to do so (OneHotEncoder, SelectFromModel, etc.)

Describe your proposed solution

I'm not sure what a good solution might be -- one start might be to implement get_feature_names() for all transformers and return just the input column names if it doesn't change them, as would be the case for a Binarizer, for example.

Describe alternatives you've considered, if relevant

Additional context

@rth
Copy link
Member

rth commented Mar 30, 2020

Thanks! The end goal of SLEP14 and proposed implementation in #16772 is to allow this.

Closing this issue to avoid duplicates, please comment in one of those exiting ones.

@rth rth closed this as completed Mar 30, 2020
@jnothman
Copy link
Member

jnothman commented Mar 31, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants