Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common tests: no print to stdout? #11885

Open
amueller opened this issue Aug 21, 2018 · 2 comments
Open

Common tests: no print to stdout? #11885

amueller opened this issue Aug 21, 2018 · 2 comments
Labels
Enhancement module:test-suite everything related to our tests module:utils

Comments

@amueller
Copy link
Member

I just saw that #10365 added a verbose=1 default argument and I don't think we have tests against that. I think we should be quite by default, but not sure we want to enforce that in check_estimator?

Generally we might want to be a bit more lenient with some things in check_estimator than we are internally, I think (say error messages), but not sure yet how to best do that.
@jnothman
Copy link
Member

jnothman commented Aug 21, 2018 via email

@jnothman
Copy link
Member

jnothman commented Aug 21, 2018 via email

@cmarmo cmarmo added Enhancement module:test-suite everything related to our tests module:utils labels Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement module:test-suite everything related to our tests module:utils
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jnothman @amueller @cmarmo