-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT - Sample weights #223
Comments
Hi @sujay-pandit, thanks for reaching out. At first sight it should be doable to add a
The calculation should simply amount to appropriate mutliplications by Would you like to send a Pull request to start working on it? We can guide you and help you through the process |
Yes, I can take that up. Thanks! |
If I start the branch, you won't be able to push to it. You need to fork the repository, and push to a branch in your fork, and then launch a pull request here. ChatGPT may also help on that matter :) |
@sujay-pandit scikit-learn has a great explanation for pull requests, you can follow it (adapting the URLs, eg replacing scikit-learn by skglm and others) : https://scikit-learn.org/stable/developers/contributing.html#how-to-contribute |
Got it! Thanks @mathurinm |
Any update here? This is a key feature for many problems, so am likewise very interested. |
Pinging @sujay-pandit on this topic |
Hey @kmedved and @mathurinm, |
Thanks @sujay-pandit |
Hi @mathurinm and @kmedved
Question: I am not expecting my penalty(MCPenalty/WeightedMCPenalty) classes to change. Is my understanding correct? Thanks! |
Hello @sujay-pandit ,
IMO
Yes indeed! No penalty should be modified when adding this new feature. Quick question from my side: for the design, do we want to modify the |
Hi @QB3
Yes. you are right; for Lipschitz computation, I will have to scale the computed values by sample weights.
Sounds good
Agreed, that will be cleaner.
Are there any more changes planned along with sample weights? I don't think the addition of sample weights is going to need a lot of changes to the existing class. If not, I would vote to just modify the existing class. |
My take: To support both classic Quadratic and weighted Quadratic in one class I see only two options:
So it's probably easier to go for two separate classes, Quadratic and WeightedQuadratic. This should make the PR straightforward. |
@mathurinm and @QB3, |
#245 is stalled, you can start a separate PR. You can even start from it, to reuse existing work.
and start working as usual on a branch. |
Description of the feature
Sklearn 'fit' functions have an option to pass 'sample_weights' array to assign importance to samples and modify the cost function accordingly.
Additional context
Wanted to use 'https://github.com/SteiMi/denseweight' with MCP.
The text was updated successfully, but these errors were encountered: