Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of near miss 3 documentation/implementation with theory #980

Open
tsoumakas opened this issue Mar 29, 2023 · 3 comments
Open

Alignment of near miss 3 documentation/implementation with theory #980

tsoumakas opened this issue Mar 29, 2023 · 3 comments
Assignees

Comments

@tsoumakas
Copy link

Hi, in the paper about near miss (https://www.site.uottawa.ca/~nat/Workshop2003/jzhang.pdf), a 4th variation is described, called "distant". The documentation of near miss 3, reads as if the original near miss 3 variation is merged with the 4th "distant" variation, perhaps because the writing of the original paper was not clear enough. The 4th variation was presented in the flow of near miss 3.

@glemaitre
Copy link
Member

Indeed. The paragraph is super confusing. Since NearMiss-3 does not allow to have selection criteria, it is more of a cleaning method (in terms of class inheritance).

I think that we can deprecate version=3 and create a new class. Regarding the most distant strategy, we could also create a new class.

@chkoar
Copy link
Member

chkoar commented Jul 9, 2023

I could take it over

@glemaitre
Copy link
Member

Happy to review it then ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants