Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Geometric-SMOTE to imbalanced-learn #881

Open
joaopfonseca opened this issue Dec 17, 2021 · 1 comment · May be fixed by #882
Open

[ENH] Add Geometric-SMOTE to imbalanced-learn #881

joaopfonseca opened this issue Dec 17, 2021 · 1 comment · May be fixed by #882

Comments

@joaopfonseca
Copy link

I'm opening this issue to discuss the possible inclusion of Geometric-SMOTE, proposed by Douzas and Bacao in this paper, in the imbalanced-learn library. The oversampler was already implemented by Georgios Douzas in this repository. It is compatible with the scikit/imbalanced-learn libraries and contains a test suite similar to the ones that already exist for SMOTE-based oversamplers. In addition, his implementation has a MIT license.

Considering that this oversampler is essentially a generalization of the generation mechanism of SMOTE (in fact, given specific hyperparameters, it mimics the behavior of SMOTE) that appears to have a consistent performance, I believe it would be a nice addition to this library.

I recently discussed this idea with both authors, which also approved the idea.

Describe the solution you'd like

Inclusion of the Geometric-SMOTE oversampler in the imbalanced-learn library. I would be happy to do this. I will make a PR referencing this issue soon. Please let me know if there is any additional information I should consider before proceeding.

joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 17, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 17, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 17, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 17, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 17, 2021
@joaopfonseca
Copy link
Author

Have to make a few changes to the original implementation in order to have it pass imblearn's tests, will open a PR once I'm done with it.

joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 18, 2021
@joaopfonseca joaopfonseca linked a pull request Dec 18, 2021 that will close this issue
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 18, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 19, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 20, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 20, 2021
joaopfonseca added a commit to joaopfonseca/imbalanced-learn that referenced this issue Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant