Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] ENH: Geometric-SMOTE implementation #882

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[MRG] ENH: Geometric-SMOTE implementation #882

wants to merge 7 commits into from

Conversation

joaopfonseca
Copy link

Reference Issue

Fixes #881

What does this implement/fix? Explain your changes.

Implements the Geometric SMOTE, as described in Geometric SMOTE a geometrically enhanced drop-in replacement for SMOTE by Douzas and Bacao.

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2021

This pull request introduces 1 alert when merging fa3ffe5 into f1abf75 - view on LGTM.com

new alerts:

  • 1 for Unused import

@joaopfonseca joaopfonseca changed the title [MRG] ENH: Geometric-SMOTE implementation [WIP] ENH: Geometric-SMOTE implementation Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021 •
edited

Codecov Report

Merging #882 (c9945c0) into master (f1abf75) will increase coverage by 0.04%.
The diff coverage is 98.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   97.21%   97.26%   +0.04%     
==========================================
  Files          96       98       +2     
  Lines        6253     6435     +182     
  Branches      712      733      +21     
==========================================
+ Hits         6079     6259     +180     
- Misses        103      104       +1     
- Partials       71       72       +1
Impacted Files Coverage Δ
imblearn/over_sampling/_smote/geometric.py 97.84% <97.84%> (ø)
imblearn/over_sampling/__init__.py 100.00% <100.00%> (ø)
imblearn/over_sampling/_smote/__init__.py 100.00% <100.00%> (ø)
...over_sampling/_smote/tests/test_geometric_smote.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1abf75...c9945c0. Read the comment docs.

@joaopfonseca joaopfonseca force-pushed the geometric-smote branch 2 times, most recently from b8907f6 to a2fadcc Compare December 20, 2021 08:09
@joaopfonseca joaopfonseca changed the title [WIP] ENH: Geometric-SMOTE implementation [MRG] ENH: Geometric-SMOTE implementation Dec 20, 2021
@joaopfonseca
Copy link
Author

joaopfonseca commented Dec 20, 2021 •
edited

@glemaitre, @chkoar I believe this is ready for revision. Some of the tests are not passing but from my understanding they are not related to the modifications in this PR.

If I may add, I just noticed imbalanced-learn's SMOTE-based over-samplers are only implementing modifications to the data selection mechanism. Geometric-SMOTE is a modification to the data generation mechanism. I hope you find this implementation useful and appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Add Geometric-SMOTE to imbalanced-learn
1 participant
@joaopfonseca