Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

252 return ensemble when alpha none #259

Closed
wants to merge 5 commits into from
Closed

252 return ensemble when alpha none #259

wants to merge 5 commits into from

Conversation

LacombeLouis
Copy link
Collaborator

Description

Fix issue #252.

This issue actually requires a bit of remodeling of multiple aspects of MapieRegressor and some fixes with regard to the relationship between agg_function, cv, ensemble.

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis self-assigned this Jan 18, 2023
@LacombeLouis LacombeLouis linked an issue Jan 18, 2023 that may be closed by this pull request
Return ensembled predictions even when alpha is None #252
Open
@LacombeLouis LacombeLouis marked this pull request as draft January 18, 2023 13:35
@LacombeLouis LacombeLouis added this to In progress in Developments Mar 2, 2023
@thibaultcordier
Copy link
Collaborator

@LacombeLouis, should we close this PR as depreciated?

Developments automation moved this from In progress to Done Sep 27, 2023
@LacombeLouis LacombeLouis deleted the 252-return-ensemble-when-alpha-none branch September 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentblot28 vincentblot28 Awaiting requested review from vincentblot28

Assignees

@LacombeLouis LacombeLouis

Labels
draft
Projects
Developments
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return ensembled predictions even when alpha is None
2 participants
@LacombeLouis @thibaultcordier