Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Giving a fraction of samples instead of a number of samples in the Subsample class #238

Open
gmartinonQM opened this issue Dec 20, 2022 · 1 comment
Open

Giving a fraction of samples instead of a number of samples in the Subsample class #238

gmartinonQM opened this issue Dec 20, 2022 · 1 comment
Labels
developers Proposed by developers. enhancement New feature or request good first issue Good for newcomers
Projects
Developments

Comments

@gmartinonQM
Copy link
Contributor

gmartinonQM commented Dec 20, 2022 •
edited

Actually, the Subsample class in mapie/subsample.py is initiated with a parameter n_samples, which is necessarily an int. This implies to hard set the number of samples used.

Would it be possible to allow n_samples to be a float between 0 and 1, interpreted as a fraction of samples to take ?
@gmartinonQM gmartinonQM added the enhancement New feature or request label Dec 20, 2022
@LacombeLouis
Copy link
Collaborator

@gmartinonQM, thank you for the suggestion, this is something we need to look into, an issue also related to #231.

@thibaultcordier thibaultcordier added this to Need triage in Developments via automation Mar 2, 2023
@thibaultcordier thibaultcordier added the good first issue Good for newcomers label Mar 3, 2023
@thibaultcordier thibaultcordier moved this from Need triage to Bugs to be fixed (Low Priority) in Developments Mar 3, 2023
@thibaultcordier thibaultcordier added the developers Proposed by developers. label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developers Proposed by developers. enhancement New feature or request good first issue Good for newcomers
Projects
Developments
Bugs to be fixed (Low Priority)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gmartinonQM @LacombeLouis @thibaultcordier