You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
error: Subclass of "VectorProtocol", "Momentum", and "Vector2D" cannot exist: would have inconsistent method resolution order [unreachable]
These errors have been suppressed using the type: ignore[unreachable] comments, but this should be fixed. The type: ignore[unreachable] comments should be removed from Vector (these are the only type: ignore[unreachable] comments left in the codebase).
Guessing it is not understanding that Type[VectorProtocol] can (sometimes) pass a subclass of Momentum check? Might be worth updating that. But not in this PR, these are (all) fine for now.
Right now
mypy
throws a bunch of errors in this particular code block -vector/src/vector/backends/awkward.py
Lines 575 to 582 in 02d4655
saying -
These errors have been suppressed using the
type: ignore[unreachable]
comments, but this should be fixed. Thetype: ignore[unreachable]
comments should be removed fromVector
(these are the onlytype: ignore[unreachable]
comments left in the codebase).The text was updated successfully, but these errors were encountered: