Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task call time tracking for successful tasks with uproot.dask #1211

Open
alexander-held opened this issue May 9, 2024 · 1 comment
Open
Labels
feature New feature or request

Comments

@alexander-held
Copy link
Member

The allow_read_errors_with_report option in uproot.dask is convenient not only to understand issues but also to study performance. While the duration seems to always get filled, I see call_time with None values for successful tasks. Unless this would be a performance issue, I believe that always (or optionally, controlled in some manner) filling this value would be useful. I would be particularly interested in using this to calculate instantaneous data rates (as this opens up the possibility to calculate data read by each task, alongside all required time stamps).

@alexander-held alexander-held added the feature New feature or request label May 9, 2024
@alexander-held
Copy link
Member Author

I also am wondering if the kwarg name for this is possibly confusing: the report can be useful even when read errors are not a concern but the kwarg makes it sound very focused on the "read error" part and not so much on the "report" part. It might not be the most obvious setting to find for people interested in more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant