Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogeneous treatment of parsing errors, with test coverage #142

Open
eduardo-rodrigues opened this issue Aug 30, 2022 · 1 comment
Open

Comments

@eduardo-rodrigues
Copy link
Member

Following up from #141 (comment):

The read_lhe type of functions and others, which parse the XML, do not all catch parsing errors.

  1. We should discuss if parsing errors should raise errors or be dealt with smoothly, as now, with print statements. Any modification to the way these errors are dealt with should be done homogeneously across the various methods.
  2. Tests should be added to cover the lines dealing with these parsing errors. That will require a special LHE file, if not several.
@eduardo-rodrigues
Copy link
Member Author

This work should probably be done taking #97 into account, to finalise on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant