Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addable weight view? #276

Open
HDembinski opened this issue Dec 9, 2019 · 4 comments
Open

addable weight view? #276

HDembinski opened this issue Dec 9, 2019 · 4 comments
Assignees
Labels
project idea Could be a fellow project

Comments

@HDembinski
Copy link
Member

I am not 100 % sure we should really do this, but it would be handy if the view of a histogram with weight storage would allow adding views and in general all the operators that also the histogram itself supports. The record array in numpy does not support addition or other operators, but since we are wrapping it, we could add support for this special record array.

@henryiii
Copy link
Member

henryiii commented Dec 9, 2019

I've thought about this a bit before and was already mildly in favor of it. Especially since you define a limit here; all operations a histogram supports should also be supported by accumulator views.

@henryiii henryiii added this to the 0.7.0 milestone Dec 9, 2019
@henryiii
Copy link
Member

henryiii commented Jan 8, 2020

I think this would actually make things like #261 (the adding different storages) easier. If we make different weight views addable, we can do the addition in Python instead of in C++, and avoid binding every possible combination of pair of histograms and keep the compile time down.

@henryiii henryiii self-assigned this Jan 8, 2020
@henryiii henryiii modified the milestones: 0.7.0, 0.8.0 Mar 11, 2020
@henryiii
Copy link
Member

henryiii commented Jun 5, 2020

Adding weight views is supported as of #368. Still are some missing operators, though.

@henryiii
Copy link
Member

henryiii commented Jun 5, 2020

So we need to be able to support the basic operators (addition, division, etc) between to views and between a view and a scalar/array (in some cases). These can be implemented in the same way as #368. That will enable performing operations on views and will enable a few other features.

@henryiii henryiii modified the milestones: 0.8.0, 1.0.0 Jul 2, 2020
@henryiii henryiii modified the milestones: 1.0.0, 0.13.0 Feb 9, 2021
@henryiii henryiii added the project idea Could be a fellow project label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project idea Could be a fellow project
Projects
None yet
Development

No branches or pull requests

2 participants