Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export remove_structure and prettyprint for dask-awkward #2856

Open
agoose77 opened this issue Nov 29, 2023 · 1 comment
Open

Export remove_structure and prettyprint for dask-awkward #2856

agoose77 opened this issue Nov 29, 2023 · 1 comment
Labels
feature New feature or request

Comments

@agoose77
Copy link
Collaborator

Description of new feature

Dask-awkward currently imports this private name.

@agoose77 agoose77 added the feature New feature or request label Nov 29, 2023
@jpivarski jpivarski added this to Unprioritized in Finalization Jan 19, 2024
@jpivarski
Copy link
Member

jpivarski commented Jan 19, 2024

Here:

https://github.com/dask-contrib/dask-awkward/blob/816eebaba6765e390c483a212d3fd3b37ec65d97/src/dask_awkward/lib/core.py#L19

The Ragged library almost had to do this, but I found a work-around. However, Ragged does use _prettyprint:

https://github.com/jpivarski/ragged/blob/444aa0f7016688ce0e9a8fa828c73cc7ac2a3210/src/ragged/_spec_array_object.py#L239-L267

Both of these should be exported as L2 "semipublic". They shouldn't be ak.* functions, but hidden in some nested submodule, though without an underscore.

This issue mentions both of them because it's as easy to do both as it is to do either one of them. We just need to decide on what their API paths will be.

@jpivarski jpivarski changed the title Export remove_structure for dask-awkward Export remove_structure and prettyprint for dask-awkward Jan 19, 2024
@jpivarski jpivarski moved this from Unprioritized to P2 in Finalization Jan 19, 2024
@jpivarski jpivarski moved this from P2 to P1 (highest) in Finalization Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Finalization
P1 (highest)
Development

No branches or pull requests

2 participants