Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard to disable pyarrow features in older pyarrow versions #2743

Open
agoose77 opened this issue Oct 6, 2023 · 1 comment
Open

Add guard to disable pyarrow features in older pyarrow versions #2743

agoose77 opened this issue Oct 6, 2023 · 1 comment
Labels
bug The problem described is something that must be fixed

Comments

@agoose77
Copy link
Collaborator

agoose77 commented Oct 6, 2023

Version of Awkward Array

main

Description and code to reproduce

As discussed in meeting.

@agoose77 agoose77 added the bug The problem described is something that must be fixed label Oct 6, 2023
@jpivarski jpivarski added this to Unprioritized in Finalization Jan 19, 2024
@jpivarski
Copy link
Member

If it takes long enough to get around to this, we might instead just require a higher minimal pyarrow version.

The testing suite is a good source of information about our minimal Arrow version. Right now, it looks like it's 13:

% fgrep -r 'pyarrow.__version' tests
tests/test_2650_arrow_array_highlevel.py:    parse_version(pyarrow.__version__) < parse_version("12.0.0"),
tests/test_2757_attrs_metadata.py:    if packaging.version.Version(pyarrow.__version__) < packaging.version.Version("13"):

But in the codebase, we only require 7:

% fgrep -r 'pyarrow.__version' src/awkward/
src/awkward/_connect/pyarrow.py:    if parse_version(pyarrow.__version__) < parse_version("7.0.0"):

If anything, it should happen at a minor version bump; see https://github.com/scikit-hep/awkward/wiki#api-breaking-changes-after-20

Check the Arrow releases page to see the temporal constraint that a new Arrow release would impose. Version 13 = August 2023 is a bit too recent to do this now. If this is being implemented before August 2024, then there should be a guard for the ak.str.* functions and a minimal version for everything else.

@jpivarski jpivarski moved this from Unprioritized to P5 in Finalization Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The problem described is something that must be fixed
Projects
Development

No branches or pull requests

2 participants