Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-compiling from osx-64 to osx-arm64 can lead to badly linked libraries #900

Open
erykoff opened this issue Mar 26, 2023 · 0 comments
Open

Comments

@erykoff
Copy link
Contributor

erykoff commented Mar 26, 2023

This is a follow-up to #589 which was not fixed correctly by #622

The issue is that in cross-compiling skip_test is marked as TRUE here

if(CMAKE_CROSSCOMPILING AND NOT CMAKE_CROSSCOMPILING_EMULATOR)
set(skip_test TRUE)
endif()
which short-circuits here
if(skip_test)
set(has_dynamic_lookup FALSE)
set(link_flags)
and therefore @isuruf's patch https://github.com/scikit-build/scikit-build/blob/main/skbuild/resources/cmake/targetLinkLibrariesWithDynamicLookup.cmake#L411-L413 is never triggered.

Not sure of the best way to work around this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@erykoff and others