Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setup.cfg package definition #591

Open
JP01 opened this issue Oct 4, 2021 · 2 comments · May be fixed by #704
Open

Support setup.cfg package definition #591

JP01 opened this issue Oct 4, 2021 · 2 comments · May be fixed by #704

Comments

@JP01
Copy link

JP01 commented Oct 4, 2021

Hi,

When building using scikit build, I seem to be required to use

  • setup.py
    setup(packages=['mypackage'])

Rather than being able to declare this in setup.cfg

  • setup.cfg
[options]
packages = mypackage

Sort of related --- #405 --- if we solved that then my issue would likely be resolved too.
@henryiii
Copy link
Contributor

Yes, this is planned. Currently any option scikit-build needs has to be passed to setup, and can't be placed in setup.cfg. (Ones it does not need are fine).

@jhale jhale mentioned this issue Jan 13, 2022
Closed
@maxnoe
Copy link

maxnoe commented Jan 31, 2022

I just ran into this. Could this be added to the documentation at least mentioning which of the options cannot be given in setup.cfg?

@henryiii henryiii mentioned this issue Jan 31, 2022
Merged
@henryiii henryiii mentioned this issue Apr 7, 2022
Open
rdbisme added a commit to rdbisme/scikit-build that referenced this issue Apr 30, 2022
@rdbisme
feat: Parse setup.cfg or equivalent to extract options that matter to…
f1ff70a 
… skbuild

Close scikit-build#591
@rdbisme rdbisme linked a pull request Apr 30, 2022 that will close this issue
Open
rdbisme added a commit to rdbisme/scikit-build that referenced this issue Apr 30, 2022
@rdbisme
feat: Parse setup.cfg or equivalent to extract options that matter to…
6387ae1 
… skbuild

Close scikit-build#591
rdbisme added a commit to rdbisme/scikit-build that referenced this issue Apr 30, 2022
@rdbisme
feat: Parse setup.cfg or equivalent to extract options that matter to…
77302b5 
… skbuild

Close scikit-build#591
henryiii pushed a commit to rdbisme/scikit-build that referenced this issue May 18, 2022
@rdbisme @henryiii
feat: Parse setup.cfg or equivalent to extract options that matter to…
fce41b0 
… skbuild

Close scikit-build#591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Parse setup.cfg or equivalent to extract options that matter to skbuild rdbisme/scikit-build
3 participants
@henryiii @maxnoe @JP01