Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DEPFILE instead of implementing a custom parser? #1028

Open
nextsilicon-itay-bookstein opened this issue Sep 15, 2023 · 2 comments
Open

Comments

@nextsilicon-itay-bookstein

It seems that cython has a --depfile argument and cmake's add_custom_command has a DEPFILE argument meant for this sort of thing. I'm not aware of the historical context, but perhaps replacing the custom regex parsing logic in UseCython.cmake with the DEPFILE functionality would both reduce maintenance burden and increase robustness?

@jcfr
Copy link
Contributor

jcfr commented Sep 15, 2023

Thanks for the suggestion, in the process of consolidating and revisiting the module implementation, will definitely look into it.

Final work will be hosted into scikit-build/cython-cmakerepository.

@nextsilicon-itay-bookstein
Copy link
Author

Cool. It's actually useful for me to have that broken out to a separate repository as well, as I've recently written cmake code to replace the python-driven build machinery (which is otherwise completely opaque to the cmake dependency graph, and rebuilds native libraries I've already built in a nested cmake invocation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants