Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from versioneer to pypa/setuptools_scm #143

Open
jcfr opened this issue May 20, 2021 · 2 comments
Open

Switch from versioneer to pypa/setuptools_scm #143

jcfr opened this issue May 20, 2021 · 2 comments

Comments

@jcfr
Copy link
Contributor

jcfr commented May 20, 2021

Would it be a good idea to move to pypa/setuptools_scm? It has nice tooling for this sort of thing; the manual versioner script doesn't have the nice overrides.

Originally posted by @henryiii in #141 (comment)


We are currently versioneer, which problem would setuptools_scm address ?

Two problems. One is we have a lot of custom code (including versioneer.py and various workarounds), while setuptools_scm simply is a PyPI package. Second, with setuptools_scm, there are environment variable overrides (specifically, I needed SETUPTOOLS_SCM_PRETEND_VERSION) that can be used for emergency operations like this one. Also, it's a PyPA standard package instead of custom code.

Originally posted by @henryiii in #141 (comment)

@henryiii
Copy link
Contributor

henryiii commented May 20, 2021

Was just about to open this. :)

@mayeut
Copy link
Contributor

mayeut commented Jul 4, 2021

I tried moving to pypa/setuptools_scm but something went wrong with the MANIFEST for sdist at least (nox failing there).
It might be related to scikit-build/scikit-build#402 (or not), needs further investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants