Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_repo_review: false positive and false negative mypy checks #386

Open
Saransh-cpp opened this issue Feb 29, 2024 · 3 comments
Open

sp_repo_review: false positive and false negative mypy checks #386

Saransh-cpp opened this issue Feb 29, 2024 · 3 comments

Comments

@Saransh-cpp
Copy link
Contributor

The MY101 and MY102 have been passing and failing (respectively) on the develop branch of PyBaMM, but it should be the other way.

Running sp_repo_review: https://learn.scientific-python.org/development/guides/repo-review/?repo=pybamm-team%2FPyBaMM&branch=develop

Actual mypy config: https://github.com/pybamm-team/PyBaMM/blob/94aa498176d0b6bb1186aa63bebd9c85f7b74bff/pyproject.toml#L272-L282

I noticed that running the develop version of sp_repo_review and repo_review does not give these false results. Please feel free to close this if this has been fixed but has not been released. Thanks!

@henryiii
Copy link
Collaborator

Just started a new release. Could you see if it still persists?

@Saransh-cpp
Copy link
Contributor Author

Thank you! But, I still see the same results for some reason.

@henryiii
Copy link
Collaborator

henryiii commented May 4, 2024

I'm not sure what's wrong with these checks in WebAssembly, but they aren't working correctly (only in WebAssembly).

Running them manually in the pyodide terminal seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants