You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that running the develop version of sp_repo_review and repo_review does not give these false results. Please feel free to close this if this has been fixed but has not been released. Thanks!
The text was updated successfully, but these errors were encountered:
The
MY101
andMY102
have been passing and failing (respectively) on the develop branch of PyBaMM, but it should be the other way.Running sp_repo_review: https://learn.scientific-python.org/development/guides/repo-review/?repo=pybamm-team%2FPyBaMM&branch=develop
Actual mypy config: https://github.com/pybamm-team/PyBaMM/blob/94aa498176d0b6bb1186aa63bebd9c85f7b74bff/pyproject.toml#L272-L282
I noticed that running the develop version of
sp_repo_review
andrepo_review
does not give these false results. Please feel free to close this if this has been fixed but has not been released. Thanks!The text was updated successfully, but these errors were encountered: