Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NU test.protocol should be flat or more predictable to traverse. #243

Open
russelljjarvis opened this issue Jun 6, 2020 · 0 comments
Open

Comments

@russelljjarvis
Copy link
Contributor

russelljjarvis commented Jun 6, 2020

It could be possible to have a stimulation_type key at the same level as other keys.

Examples:

test.protocol['Stimulation_Type'] = str('ramp')
test.protocol['PEAK_AMP'] = 1500*qt.ms
test.protocol['DELAY'] = 500*qt.ms
test.protocol['DURATION'] = 1000*qt.ms

The protocol data type could also its own class that inherits from dictionary. Then the protocol type becomes a class attribute not a dictionary key.

test.protocol.name = str('ramp') # Not even a dictionary key.

One major goal of the test protocol dictionary redesign is to do away with the aliased sub-dictionary 'injected_square_current' that currently inhabits test.protocol.

@russelljjarvis russelljjarvis changed the title NU test.protocol should be flat or easier/more predictable to traverse iterate. NU test.protocol should be flat or easier/more predictable to traverse. Jun 6, 2020
@russelljjarvis russelljjarvis changed the title NU test.protocol should be flat or easier/more predictable to traverse. NU test.protocol should be flat or more predictable to traverse. Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants