Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Druckmann Tests are not proper tests #237

Open
rgerkin opened this issue Feb 18, 2020 · 0 comments
Open

Druckmann Tests are not proper tests #237

rgerkin opened this issue Feb 18, 2020 · 0 comments
Assignees
@rgerkin
Milestone
0.3 release

Comments

@rgerkin
Copy link
Contributor

rgerkin commented Feb 18, 2020

Tests in druckmann2013.py are not actual sciunit Tests (they don't inherit from sciunit.Test) but just mimic some of a sciunit Test's methods. For compatibility with other tools that rely on sciunit, they should be refactored to derive from sciunit.Test.
@rgerkin rgerkin self-assigned this Feb 18, 2020
@rgerkin rgerkin added this to the 0.3 release milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgerkin rgerkin

Labels
None yet
Projects
None yet
Milestone
0.3 release
Development

No branches or pull requests
1 participant
@rgerkin