Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget Release Action is broken #669

Closed
jathek opened this issue Feb 21, 2024 · 8 comments
Closed

Winget Release Action is broken #669

jathek opened this issue Feb 21, 2024 · 8 comments

Comments

@jathek
Copy link

jathek commented Feb 21, 2024

Describe the bug

The action to release to winget seems broken. It hasn't successfully run for some time (if ever?). The current version on winget is croc 9.6.6.

To Reproduce

Steps to reproduce the behavior:

  1. run winget search croc
  2. version is 9.6.6, expect 9.6.12

Expected behaviour

Winget should have updated croc version.

Version

croc version v9.6.6-1e57206

Additional context

@jathek jathek added the bug label Feb 21, 2024
Copy link

Stale issue message

@jathek
Copy link
Author

jathek commented Apr 21, 2024

The current release (9.6.15) is on winget, but I assume it was added manually, because the winget action's logs still show authentication errors.

@schollz
Copy link
Owner

schollz commented May 20, 2024

I don't maintain winget, please make a PR to fix it

@jathek
Copy link
Author

jathek commented May 25, 2024

To be clear, the problem is not with winget, it's with the release action on this repo. You don't maintain that? The error logs seem to indicate a 401 error because of bad credentials. According to vedantmgoyal9/winget-releaser#240, it seems like your GitHub PAT needs to be regenerated. I don't think anyone can do that via a PR.

@schollz
Copy link
Owner

schollz commented May 25, 2024

do you have instructions for doing that?

@jathek
Copy link
Author

jathek commented May 25, 2024

EDIT2: The original PR that added the winget action to this repo lays out the required steps more clearly than I did, please check it out

OLD POST:

According to the readme of winget-releaser, you need to create a classic PAT with public_repo scope. GitHub's instructions for that are here. Afterwards, I assume you will need to copy it into the secrets for this repo and update the secret named WINGET_TOKEN. Instructions for repo secrets are here.

EDIT: After reading the readme for the winget-releaser a bit more, you will also have to fork https://github.com/microsoft/winget-pkgs, as winget-releaser defaults to using a fork on the repo owner's account (Step 2 on Getting Started). It doesn't look like you have a fork on schollz so that will be necessary too.

winget-releaser recommends using https://github.com/apps/pull on the winget-pkgs fork to keep it synced with the upstream. Installing and setting that up is a couple of clicks: you choose the account (schollz) and then you can install it for a specific repository (your fork of winget-pkgs).

@schollz
Copy link
Owner

schollz commented May 25, 2024

thanks.

winget-action is now working: https://github.com/schollz/croc/actions/runs/9236640238

@schollz
Copy link
Owner

schollz commented May 25, 2024

pull is already installed on my winget-pkgs fork btw.

I'll close this issue because winge release action is no longer broken, but please feel free to make another issue if another thing in winget is not working

@schollz schollz closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants