Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the NIST Curves? Shouldn't we be using 25591, 448? #586

Open
DiagonalArg opened this issue Aug 3, 2023 · 5 comments
Open

Why the NIST Curves? Shouldn't we be using 25591, 448? #586

DiagonalArg opened this issue Aug 3, 2023 · 5 comments
Labels
enhancement will-accept-pr

Comments

@DiagonalArg
Copy link

DiagonalArg commented Aug 3, 2023 •
edited

This looks like an interesting project, though I see you're using the NIST curves. Perhaps you don't know the history?

Should we trust the NIST-recommended ECC parameters?

My understanding is that we should be sticking with 25519 and apparently now also 448.

Magic-wormhole, for example, which seems similar to your project, uses 25519.
@DiagonalArg DiagonalArg added the bug label Aug 3, 2023
@schollz
Copy link
Owner

schollz commented Sep 20, 2023

Would happily accept a PR to use 25519

@schollz schollz added enhancement and removed bug labels Sep 20, 2023
@DiagonalArg
Copy link
Author

Would happily accept a PR to use 25519

Would love to be able to, but I don't code!

@github-actions GitHub Actions
Copy link

Stale issue message

@DiagonalArg
Copy link
Author

May be stale, but it's still a relevant enhancement ...

@schollz
Copy link
Owner

schollz commented May 20, 2024

@DiagonalArg , then please make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement will-accept-pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DiagonalArg @schollz