Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #386 with up-to-date-check on error #404

Closed
wants to merge 5 commits into from
Closed

Fixed #386 with up-to-date-check on error #404

wants to merge 5 commits into from

Conversation

mawoka-myblock
Copy link

Fixed #386 how I said.
I am really new to Go, so please give me feedback! Please don't be angry, because of bad code, but I thought, I could try to fix #386.

Thanks for feedback!

@tomkukral What do you think about my implementation?

How it works

  1. The sender tries to send
  2. This fails, because the client is not up-to-date
  3. Now, croc checks, wether the client is up-to-date or not and tells this the user with a tip how to update.
  4. If the client is up-to-date, the error is printed out as before without any notice

Deactivate it

You should be able to deactivate it, by using the arg no-update-notice

Testing is welcome!

@mawoka-myblock mawoka-myblock marked this pull request as ready for review July 10, 2021 08:59
@mawoka-myblock
Copy link
Author

croc.zip
The binary built on Linux (64-bit) for the lazy guys

@schollz
Copy link
Owner

schollz commented Sep 2, 2021

Been a long time sorry for the delay.

It looks good! One thing - what happens if the user is connecting within LAN, without access to outside internet?

@mawoka-myblock
Copy link
Author

Been a long time sorry for the delay.

It looks good! One thing - what happens if the user is connecting within LAN, without access to outside internet?

Good point, will look into it in the next days!

@mawoka-myblock
Copy link
Author

Been a long time sorry for the delay.

It looks good! One thing - what happens if the user is connecting within LAN, without access to outside internet?

Fixed it (I think)

@mawoka-myblock
Copy link
Author

Sorry of l for asking a bit inpolite, but it's there anything new, @schollz ?

schollz
schollz reviewed Oct 4, 2021
View reviewed changes
src/croc/croc.go Outdated Show resolved Hide resolved
@schollz
Copy link
Owner

schollz commented Oct 4, 2021

Thanks @mawoka-myblock !! I added one comment, just for clarity to make sure I understand everything

@mawoka-myblock
Copy link
Author

Hey, @schollz , something new?

@mawoka-myblock
Copy link
Author

I'll close the PR, because it's now over 1 year old and I don't want to waste my time resolving merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schollz schollz schollz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-update or warning that a new version is available
2 participants
@mawoka-myblock @schollz