Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: crash on MP3 restoration #129

Open
Godangel opened this issue Jun 5, 2021 · 2 comments
Open

Bug report: crash on MP3 restoration #129

Godangel opened this issue Jun 5, 2021 · 2 comments
Assignees

Comments

@Godangel
Copy link

Godangel commented Jun 5, 2021

Precomp crashes (errorlevel code -1073741819) while decompressing mp3-like data placed in zlib (not sure is it real mp3 or just some random data detected as mp3). Sample data provided. Tested on both 0.4.7 and 0.4.6.
precomp -cn -intense datafile.dat [success]
precomp -r datafile.pcf [crashes]

If I use param -t-3 while compressing, decompression works just fine.

mp3data-inside-zlib.zip

@schnaader schnaader self-assigned this Jun 6, 2021
@schnaader schnaader added this to the Precomp v0.4.8 milestone Jun 6, 2021
@schnaader
Copy link
Owner

The crash can be reproduced, I've managed to isolate the MP3 stream that causes it. So this most likely is a packmp3 issue, I will investigate this further.

invalid_mp3.zip

@Godangel
Copy link
Author

More sample data. With this one precomp doesn't crash, but rather produces corrupted file on decompression without any warnings. Steps to reproduce error are the same:
precomp -cn -intense datafile.dat [success]
precomp -r datafile.pcf [success, but results in corrupted file]

mp3data-inside-zlib-nocrash.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants