Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL.createObjectURL with media streams is deprecated and will be removed in M68, around July 2018 #134

Open
DysAhm opened this issue Mar 29, 2018 · 3 comments

Comments

@DysAhm
Copy link

DysAhm commented Mar 29, 2018

[Deprecation] URL.createObjectURL with media streams is deprecated and will be removed in M68, around July 2018. Please use HTMLMediaElement.srcObject instead. See https://www.chromestatus.com/features/5618491470118912 for more details.
@schmich

@ReeceM
Copy link

ReeceM commented Apr 6, 2018

I believe it is already removed from the wedkit standard Webkit

Also the latest release on npm does not reflect the changes supposedly committed with bb59b1e

Making these edits in the npm src files fixed and error where the camera feed was not put in the <video> element.

@schmich please could you make this reflect in the NPM repo as this is a straight forward library for QR scanning.

@arjunkgit
Copy link

Hello @ReeceM / @schmich,

I'm not using npm to compile the any of files which are mentioned in bb59b1e.

I'm only using instascan.min.js file to scan the code. Could you please let me know what changes I need to update in min file to remove the Deprecation warning message.

Thanks

@ReeceM
Copy link

ReeceM commented Jul 20, 2018

Hi @arjunkgit,

What I suggest you do is download this source file,

https://rawgit.com/schmich/instascan-builds/master/instascan.min.js

It does run as it is. Short of compiling a copy of the minified file again with the fixes or editing the file to remove the line that is the problem. Running it through a diff checker, the whole file is different from the release version. So I suggest you just use the sam file used in the demo.

I also suggest for sanity sake use the following shim file too

webrtc-adapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants