Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase code for failing PRs #2992

Closed
RichardWallis opened this issue Nov 17, 2021 · 12 comments
Closed

Rebase code for failing PRs #2992

RichardWallis opened this issue Nov 17, 2021 · 12 comments
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).

Comments

@RichardWallis
Copy link
Contributor

Following the fix of #2946, caused by the upgrading of some dependant python libraries such as rdflib, PRs that were failing (such as #2958) now pass CI tests.

For the failing PRs to pass the CI tests the code behind the PR had to be rebased against the current state of the main branch. This was simple for PRs based on branches in this repository.

However several PRs (#2941, #2953, #2965, #2985 and possibly #2738) are hosted in branches in other forked repositories. In these cases the code in those repositories, should be rebased against the main branch in this repository.

This issue is to capture to actions to achieve that

@gmackenz
Copy link
Contributor

How do I do a Rebase, I am very unfamiliar with github.

@RichardWallis
Copy link
Contributor Author

RichardWallis commented Nov 17, 2021

@gmackenz Let's see how others get on with this question over the next few days. Then we may come up with an easy shared way to do it.

Git always has several ways to do anything!

@danbri
Copy link
Contributor

danbri commented Nov 17, 2021

I hate to make work for contributors, but my go-to git documentation is https://xkcd.com/1597/

@dr-shorthair
Copy link

I've definitely done that.

@dr-shorthair
Copy link

(saved my work elsewhere, and made a fresh clone)

@mattgarrish
Copy link
Contributor

mattgarrish commented Nov 18, 2021

If you want to do it straight from github, I just realized they have a "Fetch upstream" button in your fork. If there are no merge conflicts, it should update everything for you. If not, it'll open a pull request so you can resolve the conflicts.

The old fashioned way I followed is to open a pull request yourself to merge main from here into your fork.

@RichardWallis
Copy link
Contributor Author

@mattgarrish great suggestion, but where is this wonderful button. I don't see it on the Github site.

Also. Github documentation on how to merge from upstream into a fork:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/merging-an-upstream-repository-into-your-fork

@mattgarrish
Copy link
Contributor

mattgarrish commented Nov 18, 2021

If you go to a fork, it should appear in the Code tab just below the various buttons at the top (at the right edge):

Fetch upstream button

It's also documented here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@RichardWallis
Copy link
Contributor Author

Ah that is not visible to me when I view someone else's fork repo. Presumably you need to be the owner.

@philbarker
Copy link
Contributor

I can confirm that it works for me on forks that I own. Thank you @mattgarrish !

@mattgarrish
Copy link
Contributor

Presumably you need to be the owner.

Yes. If you don't have write access, you could only request the owner sync their repository by going into the pull request tab and open a pull request that pulls the latest changes in this repository across to theirs.

If you want to prompt fixes for the broken PRs, you'd need to open a PR for each one. For example, you could update 2965 here: acka47/schemaorg@main...schemaorg:main

@github-actions
Copy link

This issue is being nudged due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Development

No branches or pull requests

6 participants