Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari Support #92

Open
alex-cory opened this issue Oct 27, 2020 · 6 comments
Open

Safari Support #92

alex-cory opened this issue Oct 27, 2020 · 6 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@alex-cory
Copy link

Are there any plans to support Safari? Are there any ways to workaround this?

@alex-cory alex-cory added the bug Something isn't working label Oct 27, 2020
@CryogenicPlanet
Copy link
Member

Hey, @alex-cory the https://caniuse.com/sharedarraybuffer says that it can be enabled on Safari using a flag. This could be a workaround, but let me try to dig up an old mac and see if I can get it to work.

@alex-cory
Copy link
Author

To be specific, mobile Safari.

@CryogenicPlanet
Copy link
Member

Hey, @alex-cory not planning to support mobile browsers at this time, there are a couple of reasons for this:

  • Almost all of them required flags to be enabled to support the required features
  • If getting a user to enable a flag on desktop is hard, it is 10x harder on mobile
  • Personally, I don't see the complete use case for modfy on mobile, that is you are not often dealing with formats(they are heavily abstracted away). Most galary apps have some video editing functionality and there are tons of easy to use native apps that can perform the more complex tasks.

That being said, I would love to be able to support mobile sometime in the future, when the browsers natively support the required features.

Related to #87

@CryogenicPlanet CryogenicPlanet added the wontfix This will not be worked on label Oct 27, 2020
@alex-cory
Copy link
Author

If you were to try and solve this problem today without SharedArrayBuffer or Atomics, what approach would you take? Is it even possible right now? I'm interested in making a PR, but need a little guidance.

@CryogenicPlanet
Copy link
Member

Hey, @alex-cory so under the hood for web assembly we use https://github.com/modfy/ffmpeg.wasm a forked version of https://github.com/ffmpegwasm/ffmpeg.wasm.

Here we have made some change with promise handling and added certain headers to support firefox (the original repository only supports chrome). I would have to look into how to re-engineer the project to not use SharedArrayBuffer but I assume it would be quite a large task.

Few other things to note, SharedArrayBuffer was disabled due to Spectre and Meltdown, and its meant to be a temporary patch, so we can expect default support sometime in the future(yes, browser features are super slow). Finally, if I am not wrong SharedArrayBuffer has to do with Wasm Multithreading too, so we can except a decent performance hit without using it.

That being said, I am totally down to collaborate on trying to build a solution without SharedArrayBuffer to support more platforms. If you are open to it, I can send a calendy link on Twitter and we can setup a call where I can better explain the project

@alex-cory
Copy link
Author

I will definitely take you up on this, I just need a little time. I will comment back here when I'm ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants