Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #1685

Open
hacetin opened this issue May 3, 2024 · 1 comment
Open

New release #1685

hacetin opened this issue May 3, 2024 · 1 comment

Comments

@hacetin
Copy link

hacetin commented May 3, 2024

When do you plan the next release? I see plans for new release in https://github.com/scalapb/ScalaPB/blob/master/CHANGELOG.md

We need it because of two reasons:

  • scalapb-validate:-core0.3.5 fails to build with scalapb:0.11.5, so version upgrades may help. Some errors:
    [Error] /Users/.../build/generated/source/proto/main/scalapb/com/google/protobuf/descriptor/FeatureSet.scala:486:108: type StringFieldValidation is not a member of object com.google.protobuf.DescriptorProtos.FeatureSet
    [Error] /Users/.../build/generated/source/proto/main/scalapb/com/google/protobuf/descriptor/FieldOptions.scala:853:47: type mismatch;
      found   : com.google.protobuf.DescriptorProtos.Edition => com.google.protobuf.DescriptorProtos.FieldOptions.EditionDefault.Builder
      required: String => ?
    [Error] /Users/.../build/generated/source/proto/main/scalapb/com/google/protobuf/descriptor/FileDescriptorProto.scala:293:45: type mismatch;
      found   : com.google.protobuf.DescriptorProtos.Edition => com.google.protobuf.DescriptorProtos.FileDescriptorProto.Builder
      required: String => ?
    
  • To use protobuf java v4
@thesamet
Copy link
Contributor

thesamet commented May 3, 2024

  1. The first bullet seems like a bug - can you provide instructions to reproduce or better yet a minimal project that demonstrates it?
  2. Until we have a release, you should be able to use scalapb 0.11.x with protobuf-java v4. Set protocVersion to say 4.26.1, and add protobuf-java 4.26.1 as a library dependency.

There is a snapshot release being made for master for each commit. You can see the version numbers here: https://oss.sonatype.org/content/repositories/snapshots/com/thesamet/scalapb/compilerplugin_2.12/ - latest right now is 0.11.15+43-7fafdd61-SNAPSHOT
I'd start a preview release for ScalaPB 0.12 so early adopters can follow on upcoming changes, but I don't have a timeline for a final 0.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants