Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add -release flag to correctly compile Scala code #2031

Open
4 tasks
tgodzik opened this issue Apr 6, 2023 · 3 comments
Open
4 tasks

Automatically add -release flag to correctly compile Scala code #2031

tgodzik opened this issue Apr 6, 2023 · 3 comments
Labels
integrations priority / high Any change that has a high priority to be fixed because of its immediate consequences.
Milestone

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Apr 6, 2023

Currently if we use a newer version of Java for Bloop and try to compile with an older JDK we will get proper bytecode generated for Java files as they fork the compilation, however the same will not happen for Scala code.

For that to work we should automatically add --release flag similar to how ScalaCLI does it for all bloop plugins:

  • maven
  • Gradle
  • sbt
  • mill

This also allow us to only run Bloop on JDK 17 and use the improved support from scala-cli/bloop-core (or even migrate to it)

@tgodzik tgodzik added integrations priority / high Any change that has a high priority to be fixed because of its immediate consequences. labels Apr 6, 2023
@tgodzik tgodzik added this to the Bloop v1.5.7 milestone Apr 6, 2023
@ckipp01
Copy link
Member

ckipp01 commented Apr 7, 2023

For that to work we should automatically add --release flag similar to how ScalaCLI does it for all bloop plugins:

Do you have a link handy to show where/how scala-cli does it?

@tgodzik
Copy link
Contributor Author

tgodzik commented Apr 7, 2023

For that to work we should automatically add --release flag similar to how ScalaCLI does it for all bloop plugins:

Do you have a link handy to show where/how scala-cli does it?

That is a good question, I can't find it quickly so I asked the team 😓

@tgodzik
Copy link
Contributor Author

tgodzik commented Apr 7, 2023

@tgodzik tgodzik modified the milestones: Bloop v1.5.7, Bloop 1.5.10 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations priority / high Any change that has a high priority to be fixed because of its immediate consequences.
Projects
None yet
Development

No branches or pull requests

2 participants