Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Change experience" modal #3033

Closed
philippotto opened this issue Aug 10, 2018 · 1 comment
Closed

Improve "Change experience" modal #3033

philippotto opened this issue Aug 10, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@philippotto
Copy link
Member

Context: Users table

Editing experiences for users is not very intuitive at the moment. Multiple things can be improved:

  • When clicking the experience labels in the table, the edit-experience-modal should show up (at the moment, you have to check the checkbox in the right row and then click a button)
  • The modal should have some description text to explain what experience domains are at all.
  • Editing experiences itself should be improved (see below).

To change an experience level, an admin has to type in manually a domain and then type in a new value (which is suboptimal). The modal doesn't even show the already existing experiences?
The three buttons "increase", "set" and "delete" seem a bit cumbersome and not intuitive.

I'd imagine a table like this:

ProTracerDomainA          [-]   3   [+]    [trash icon]   
ProTracerDomainB          [-]   3   [+]    [trash icon]
[Add new experience domain]-button

[Save] [Cancel]

After the button is clicked:

ProTracerDomainA          [-]   3   [+]    [trash icon]   
ProTracerDomainB          [-]   3   [+]    [trash icon]
[input box (antd tag mode) for name]         [-]   1   [+]    [trash icon]

[Save] [Cancel]

The numbers itself should probably be input fields, too, so that you can input 90 without having to click the button 89 times :)

However, beware:
The modal can be used to change the experience domain for several users at once. If the users have different existing domains, the above approach for rendering domains does not work. We need to think about a good way here.

@philippotto
Copy link
Member Author

Ok, we agreed on the following in the discussion:

If a single user is selected for editing, we list all experience domains (see UI mockup in the first comment).
If multiple users are selected, we stick to the current UI, with the following differences:

  • the top of the modal lists the intersection of the exp domains of all users (e.g., "The selected users have the following domains in common: ...")
  • the experience input is a antd select (see Make experience field in task creation an antd select component #3031)
  • if the user inputs a domain which is not possessed by all users, we show a light-weight warning (shown immediately; not on ok click), like "The experience domain you selected is not owned by all of the selected users. Changing, increasing or deleting the domain will affect all selected users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants