You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to munit 1.0.0-M11 release - lampepfl/gears#64 (comment) - in this release probably some garbage file generated using 0.4.x where packaged together with NIR files generated for 0.5.x.
The one identified file that could have contained old version of NIR was from Reflectively Instantiated class - in the 0.5.x the symbol names of them are fixed, previously they were create non-standard name partially based on mangle name of the owner class. Because build tool does not clean the target/scala-X/classes directory this single file could have survived the compilation after upgrade to 0.5.0 without override as there would be no file generated with that name in 0.5.x.
Even though this issue was related to contamination of release build for munit, we should be able to prepare toolchain for this kind of issues. We should ignore NIR files that have incompatible format, instead of crashing build using exception. Probably this file was only read when scanning for NIR files to gather required information and it would not be used when class loading.
Related to munit 1.0.0-M11 release - lampepfl/gears#64 (comment) - in this release probably some garbage file generated using 0.4.x where packaged together with NIR files generated for 0.5.x.
The one identified file that could have contained old version of NIR was from Reflectively Instantiated class - in the 0.5.x the symbol names of them are fixed, previously they were create non-standard name partially based on mangle name of the owner class. Because build tool does not clean the
target/scala-X/classes
directory this single file could have survived the compilation after upgrade to 0.5.0 without override as there would be no file generated with that name in 0.5.x.Even though this issue was related to contamination of release build for munit, we should be able to prepare toolchain for this kind of issues. We should ignore NIR files that have incompatible format, instead of crashing build using exception. Probably this file was only read when scanning for NIR files to gather required information and it would not be used when class loading.
Steps to reproduce:
git clone https://github.com/scalameta/munit -b v1.0.0-M1
sbt +munitNative/compile
sbt +munitNative/publishLocal
The text was updated successfully, but these errors were encountered: