Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with Nextcloud #213

Open
sunjam opened this issue Oct 16, 2020 · 3 comments
Open

Login with Nextcloud #213

sunjam opened this issue Oct 16, 2020 · 3 comments
Labels
enhancement Let's make it better! help wanted I need some help with this.

Comments

@sunjam
Copy link

sunjam commented Oct 16, 2020

Oauth would Nextcloud users to log into Pepperminty-wiki. Relates to the roadmap for possible future integration with Nextcloud.

@sbrl
Copy link
Owner

sbrl commented Oct 24, 2020

Hey there - thanks for opening this issue @sunjam! Sorry I'm late replying here - October is a busy month over in tldr-pages because of hacktoberfest.

OAuth2 support would be nice, but it's pretty complicated the last time I looked into it - I'd prefer to use a library to handle the backend complexities of OAuth2. Do you know of any super lightweight ones (i.e. a single file) at all?

I'm also somewhat wary about this bit in the documentation you link to:

Without scopes and restrictable access it is not recommended to use a Nextcloud instance as a user authentication service.

I wonder if it's possible to, as soon as the OAuth2 process has been completed and the user is logged in, to throw away the OAuth2 login token and maintain our own internal state there for security reasons - since the nextcloud docs say that the token given to us by them has the potential for full read/write access to the user's Nextcloud account, which we don't want to have.

@sbrl sbrl added enhancement Let's make it better! help wanted I need some help with this. labels Oct 24, 2020
@sunjam
Copy link
Author

sunjam commented Nov 8, 2020

In that case I'll close this due to security concern. Thanks.

@sunjam sunjam closed this as completed Nov 8, 2020
@sbrl
Copy link
Owner

sbrl commented Nov 10, 2020

Oh, no worries @sunjam! OAuth2 is definitely something I'd like to look at in the future, maybe as part of a larger login overhaul. If possible, LDAP support would be nice too - perhaps we could design sort of a plugin-based login system.

To address what I think is your original intent, login with Nextcloud is something we definitely need to tackle. Perhaps this issue could be reopened and renamed to Login with Nextcloud instead?

@sunjam sunjam changed the title Oauth 2 support for user login Login with Nextcloud Nov 11, 2020
@sunjam sunjam reopened this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Let's make it better! help wanted I need some help with this.
Projects
None yet
Development

No branches or pull requests

2 participants